github-merge: omit ACKs in quoted comments or with markdown indentation #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review ACK 9333d5f |
katesalazar
reviewed
Jul 18, 2023
| if "ACK" in l | ||
| and head_abbrev in l | ||
| and not l.startswith("> ") # omit if quoted comment | ||
| and not l.startswith(" ") # omit if markdown indentation |
There was a problem hiding this comment.
suspicious eyes
can't stop feeling like this line gonna hit someone eventually
|
Concept ACK 9333d5f |
Jess25051980
approved these changes
Mar 12, 2024
laanwj
approved these changes
Mar 12, 2024
|
ACK 9333d5f |
jonatack
deleted the
2023-06-omit-acks-in-quoted-comments-and-markdown-indentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid counting an ACK if it is in a quoted comment or with markdown indentation, when present in a review before the actual ACK. See bitcoin/bitcoin#27334 (comment) for an example.