Use Gemfile for bundler #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Gemfile, updated README.md and .travis.yml to use it with bundler. This provides the following features: - Travis will automatically pull the dependencies from the Gemfile - Travis will cache the dependencies, speeding up CI testing - Simplifies instructions if we add new dependencies - Gemfile.lock makes sure everyone has exactly the same version of the dependencies, helping to stop some "works for me"/"doesn't work for me" bugs - Devs who use rvm will automatically have the correct version of `ruby` selected for them Also removed ruby 2.2.3 from the .travis.yml since it causes the build to run twice for each ruby version. Since we're not not doing app development, we don't usually need to worry about forward compatability at the minor-point-release level. Also also corrected indent for env variable.
| ## Disable external link checking to prevent spurious failures because | ||
| ## of other people's downtime. This can also avoid wasting their | ||
| ## bandwidth. | ||
| script: bundle exec jekyll build && bundle exec htmlproof --disable-external ./_site |
There was a problem hiding this comment.
Do we really want to not check external links? I thought it was a good check to catch links that go stale months or years later when no-one is looking.
There was a problem hiding this comment.
I think it's a good manual check that can be run time-to-time. But as an automated check it has two problems:
- It causes spurious CI failures when a server is temporarily unreachable.
- It sends the message that people should be polluting their PRs with unrelated link changes in order to fix CI failures.
ivan98q
added a commit
to ivan98q/bitcoincore.org
that referenced
this pull request
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Gemfile, updated README.md and .travis.yml to use it with
bundler. This provides the following features:
dependencies, helping to stop some "works for me"/"doesn't work
for me" bugs
rubyselected for them
Also removed ruby 2.2.3 from the .travis.yml since it causes the build
to run twice for each ruby version. Since we're not not doing app
development, we don't usually need to worry about forward compatability
at the minor-point-release level.
Also also corrected indent for env variable to get rid of a Travis error.