Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use black navigation bar, use different logo #27

Merged
merged 2 commits into from
Jan 15, 2016
Merged

Use black navigation bar, use different logo #27

merged 2 commits into from
Jan 15, 2016

Conversation

jonasschnelli
Copy link
Contributor

Would look like:
bildschirmfoto 2016-01-14 um 10 20 57

@maflcko
Copy link

maflcko commented Jan 14, 2016

Awesome! ACK, looks more legit now.

@carnesen
Copy link

Looks great!

On Thu, Jan 14, 2016 at 4:22 AM MarcoFalke notifications@github.com wrote:

Awesome! ACK, looks more legit now.

—
Reply to this email directly or view it on GitHub
#27 (comment).

@jonasschnelli jonasschnelli mentioned this pull request Jan 14, 2016
Merged
@harding
Copy link
Contributor

harding commented Jan 14, 2016

Tested ACK. I agree that it looks a lot nicer now. Thanks!

@btcdrak btcdrak added the design label Jan 14, 2016
@jonasschnelli jonasschnelli force-pushed the 2016/01/bw_style branch 2 times, most recently from 5aa9fcb to a6853a4 Compare January 14, 2016 18:05
@jonasschnelli
Copy link
Contributor Author

Rebased.
Adapted the nested menus for the black style.
Slightly reduce the required size for the logo. The logo now auto-resizes and does not overflows into the navigation anymore.

@maflcko
Copy link

maflcko commented Jan 14, 2016

Concept Re-ACK a6853a4

@jonasschnelli
Copy link
Contributor Author

Testsite: https://coresitetest.jonasschnelli.ch

@maflcko
Copy link

maflcko commented Jan 14, 2016

Tested ACK a6853a4 ;)

@maflcko
Copy link

maflcko commented Jan 14, 2016

Can you make the white highlights have round edges?

screenshot from 2016-01-14 19-49-59

@jonasschnelli
Copy link
Contributor Author

Added a commit: add round corners to the active navigation item state.

bildschirmfoto 2016-01-14 um 21 22 32
bildschirmfoto 2016-01-14 um 21 22 13

@btcdrak
Copy link
Contributor

btcdrak commented Jan 15, 2016

Looks good, let's merge it... I've a couple of niggles but they can be worked out later.

@maflcko
Copy link

maflcko commented Jan 15, 2016

ACK. Let's merge the eye candy.

btcdrak added a commit that referenced this pull request Jan 15, 2016
@btcdrak
Merge pull request #27 from jonasschnelli/2016/01/bw_style
f511d36 
Use black navigation bar, use different logo
@btcdrak btcdrak merged commit f511d36 into bitcoin-core:gh-pages Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
design merge scheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonasschnelli @maflcko @carnesen @harding @btcdrak