Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize dependencies and add CI that matches the build server #963

Merged
merged 2 commits into from
May 5, 2023

Conversation

achow101
Copy link
Member

@achow101 achow101 commented May 5, 2023

We don't need all of the github pages dependencies, just jekyll and a few others.

Also add a CI task that behaves similarly to the site's build server so we can catch issues earlier.

The website is not hosted with github pages, there's no need to use all
of its dependencies as we do not use them either.
This is similar to the build server setup, so it should help us with
catching and debugging issues.
Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5948514

built fine locally. CI is green and the yaml looks fine.

@glozow glozow merged commit dee2105 into bitcoin-core:master May 5, 2023
2 checks passed
@TheBlueMatt
Copy link
Contributor

This is awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants