Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add "macOS arm64" task #133

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jun 29, 2022

This PR adds "macOS arm64" task which creates a downloadable binary for macOS systems based on Apple M1.

Windows
macOS x86_64
macOS arm64_64
Android

The downloaded file on macOS M1:

% lipo -info ./Downloads/insecure_mac_arm64_gui
Non-fat file: ./Downloads/insecure_mac_arm64_gui is architecture: arm64

IMPORTANT NOTE

macOS M1 requires all binaries must be signed. To apply ad-hoc code signing to the downloaded insecure_mac_arm64_gui, run:

% codesign -s - ./Downloads/insecure_mac_arm64_gui  

@hebasto hebasto force-pushed the 220629-ci-m1 branch 3 times, most recently from 98a49f7 to 42816f8 Compare June 29, 2022 17:33
@hebasto hebasto changed the title ci: Add "macOS M1" task ci: Add "macOS arm64" task Jun 29, 2022
@hebasto hebasto marked this pull request as ready for review June 29, 2022 21:28
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the downloaded arm64 binary does not run. If you double click the binary from within the finder, the terminal will open up and you will see output such as:

xyz@23:34 ~ ₿ /Users/xyz/Downloads/insecure_mac_arm64_gui ; exit;
zsh: killed     /Users/xyz/Downloads/insecure_mac_arm64_gui

Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

If you attempt to run the binary from the terminal you will see:

xyz@23:34 Downloads ₿ ./insecure_mac_arm64_gui 
zsh: killed     ./insecure_mac_arm64_gui

@GBKS
Copy link
Contributor

GBKS commented Jun 30, 2022

tACK. Note that I could not test whether the page transitions animate more smoothly now, since this version of the application does not have any page transitions. We'll have to test what with the updates on #124.

@jarolrod see the note about signing at the bottom of the issue. After signing it worked for me.

@hebasto hebasto merged commit 09b18e9 into bitcoin-core:main Jun 30, 2022
@hebasto hebasto deleted the 220629-ci-m1 branch June 30, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants