Fix QSettings initialization failure on startup when parsing invalid arguments #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
changed the title
pablomartin4btc
force-pushed
the
fix-QSetting-init
branch
from
6b86e35
to
ab02746
Compare
pablomartin4btc
force-pushed
the
fix-QSetting-init
branch
2 times, most recently
from
a522ca5
to
fb7b225
Compare
Moving bitcoin.cpp app setters before parsing command-line options; otherwise if invalid parameters are passed, QSetting initialization would fail and the corresponding error will be displayed on terminal.
pablomartin4btc
force-pushed
the
fix-QSetting-init
branch
from
fb7b225
to
e1b0798
Compare
|
Rebased. |
johnny9
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
ACK e1b0798
Before changes:
qrc:/qml/controls/Theme.qml:13:5: QML Settings: Failed to initialize QSettings instance. Status code is: 1
qrc:/qml/controls/Theme.qml:13:5: QML Settings: The following application identifiers have not been set: QVector("organizationName", "organizationDomain")
After:
No qml errors seen
|
Thanks @MarnixCroes, @D33r-Gee and @johnny9 for testing the bugfix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #361.
After applying the fix, no QML source code errors should be displayed on the terminal: