Add PeerDetails page [Alternative] #388
Draft
+510
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
force-pushed
the
peer-details-alternate
branch
from
b7161c5
to
4909ba5
Compare
johnny9
reviewed
Mar 1, 2024
| value: Row { | ||
| IconButton { | ||
| iconLocation: details.direction === "Inbound" ? "image://images/arrow-down" : "image://images/arrow-up" | ||
| icon.height: 9 |
There was a problem hiding this comment.
Suggested change
| icon.height: 9 | |
| icon.height: 11 |
Add 2 pixels to compensate for the ~20% padding around the icon source. Makes it closer to the figma and also easier to see.
johnny9
reviewed
Mar 1, 2024
|
|
||
| spacing: 10 | ||
| Pane { | ||
| id: key_field |
johnny9
reviewed
Mar 1, 2024
| } | ||
| } | ||
| Component { | ||
| id: peer_details |
johnny9
reviewed
Mar 1, 2024
| ValText { text: permissionsRow.permissionsValue; } | ||
| } | ||
| Component { | ||
| id: not_permissioned |
johnny9
reviewed
Mar 1, 2024
| KeyValueRow { key: KeyText { text: qsTr("User agent"); } value: ValText { text: details.userAgent; }} | ||
| KeyValueRow { key: KeyText { text: qsTr("Services"); } value: ValText { text: details.services; }} | ||
| KeyValueRow { | ||
| id: transaction_relay_row |
MarnixCroes
reviewed
Mar 6, 2024
| bottomPadding: 5 | ||
|
|
||
| KeyValueRow { key: KeyText { text: qsTr("Address"); } value: ValText { text: details.address; color: Theme.color.neutral9; }} | ||
| KeyValueRow { key: KeyText { text: qsTr("VIA"); } value: ValText { text: details.addressLocal; color: Theme.color.neutral9; }} |
There was a problem hiding this comment.
maybe VIA could be displayed only when it has a value?
for example, for an onion peer there is no VIA
There was a problem hiding this comment.
I do agree, unless there's reason for leaving it empty.
There was a problem hiding this comment.
As I saw in previous approach of the PeerDetails page #387, perhaps a "N/A" could be displayed or "-"(as it's shown in the description above)? (e.g.)
|
draft until I fix the line spacing when text wraps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #387 which expands to think about a reusable row component, allowing to load any element(s) to the value field, not hardcoding in a height of 21 for a row (but still ensuring it's a minimum of 21), proper icon usage for N/A cases, dummy net indicators in place
TODO:
Link to github actions build artifacts.