Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" #148

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Dec 9, 2020

The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense

Originally bitcoin/bitcoin#17463, but rewritten here much simpler based on other merged changes.

The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8775691, tested on Linux Mint 20.1 (x86_64, Qt 5.12.8):

Screenshot from 2021-01-10 20-28-59

Also verified that button text is translated properly (it is not the case on master):

Screenshot from 2021-01-10 20-37-53

@maflcko maflcko merged commit cb2c578 into bitcoin-core:master Jan 13, 2021
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 13, 2021
The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense

Github-Pull: #bitcoin-core/gui#148
Rebased-From: 8775691
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Sep 21, 2021
The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense

Github-Pull: #bitcoin-core/gui#148
Rebased-From: 8775691
(cherry picked from commit 7bf3ed4)
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Sep 21, 2021
The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense

Github-Pull: #bitcoin-core/gui#148
Rebased-From: 8775691
(cherry picked from commit 7bf3ed4)
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Sep 22, 2021
The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense

Github-Pull: #bitcoin-core/gui#148
Rebased-From: 8775691
(cherry picked from commit 7bf3ed4)
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants