peers-tab: bug fix right panel toggle #202
Conversation
|
What is this fixing? |
|
Hiding the detailWidget is incorrect - hiding the right panel of the splitter view is the correct usage of the splitter view. This change uses the splitter view correctly. Running the code will make what the change addresses readily apparent. |
There was a problem hiding this comment.
ACK 8353e8c
This is a welcome change as it makes more efficient use of the peers tab window. On master the peer detail widget is always shown even if no peer has been selected. This pr introduces a toggle feature where the peer detail widget will only pop up when a peer has been selected.
Checked and confirmed that when multiple peers are selected the peer widget will still hide (introduced in #13)
There was a problem hiding this comment.
ACK 8353e8c tested rebased on current master. Behavior is initially a bit surprising but this would allow more columns to be added to the peers tab window. Verified that selecting more than one peer, clicking on a column header, or running disconnectnode "" <currently-selected-peer-id> in the console (or on the CLI with the -server startup option) returns the window to its full size. If this is merged, it might be nice to have an obvious way to close the details area like a clickable "close this" icon in the upper left corner of the area.
|
@jonatack - thank you! yes - this is the goal! Part of a larger common initiative to make the peers tab contain more info and be more useful - a better use of GUI real estate. :) This PR is sparse - as to not break other work being done. :) |
|
A UX note: to clear selection use |
8353e8c peers-tab: bug fix right panel toggle (randymcmillan) Pull request description: Initial Presentation:  When node row selected - panel is presented:  When network disabled - right panel is hidden:  ACKs for top commit: jarolrod: ACK 8353e8c jonatack: ACK 8353e8c tested rebased on current master. Behavior is initially a bit surprising but this would allow more columns to be added to the peers tab window. Verified that selecting more than one peer, clicking on a column header, or running `disconnectnode "" <currently-selected-peer-id>` in the console (or on the CLI with the `-server` startup option) returns the window to its full size. If this is merged, it might be nice to have an obvious way to close the details area like a clickable "close this" icon in the upper left corner of the area. Talkless: tACK 8353e8c, tested on Debian Sid. Made `bitcoind` connect to `bitcoin-qt` with the PR changes, and after I quit the `bitcoind` instance, right panel do disappear, compared to the previous commit where it didn't. Tree-SHA512: 8fc156f40bdd61e3ba8db333c729a2a07fd5f0fd1eed56f2fd2aa5ae5864756f8ab6fad74ae2fb0552ee7518b6d489f5800709e6c80c6f31f61fd8ce21cece5f
|
When no peer is selected, and one calls a context menu, it causes the peer selection with a layout change. I found such a behavior distracting. |
Initial Presentation:
When node row selected - panel is presented:
When network disabled - right panel is hidden: