Fix PaymentServer::handleURIOrFile warning message

[hebasto]

GUIUtil::parseBitcoinURI does not check address validity. Therefore, an invalid address cannot cause parsing failure.

An invalid address case is covered by its own message.

This PR fixes the warning messages.

[Talkless]

utACK 2434d00, no any testing, just built on Debian Sid with Qt 5.15.2

[hebasto]

Updated 2434d00 -> 45ebd9e (pr225.01 -> pr225.02):

• rebased on top of the Remove user input from URI error message #280
• dropped all refactoring changes

[hebasto]

@prayank23

Do you mind reviewing this PR?

[ghost]

GUIUtil::parseBitcoinURI does not check address validity. Therefore, an invalid address cannot cause parsing failure.

If address validity is not checked, can it be the cause for parsing failure?

An invalid address case is covered by its own message "Invalid payment address %1".

Invalid address case is covered by IsValidDestination() and updated in #280 however, if code for else statement is executed can we assume address was never checked for validity?

gui/src/qt/paymentserver.cpp

Line 252 in 4a26705

else

[hebasto]

GUIUtil::parseBitcoinURI does not check address validity. Therefore, an invalid address cannot cause parsing failure.

If address validity is not checked, can it be the cause for parsing failure?

Internally the GUIUtil::parseBitcoinURI uses the QUrlQuery class, so if an invalid address does not contain delimiters, it shouldn't cause parsing failure.

An invalid address case is covered by its own message "Invalid payment address %1".

Invalid address case is covered by IsValidDestination() and updated in #280 however, if code for else statement is executed can we assume address was never checked for validity?

I think we can.

[hebasto]

Rebased 45ebd9e -> 5b20d46 (pr225.02 -> pr225.03) on top of the recent CI changes.

[Talkless]

re-utACK 5b20d46 after rebase.

[jarolrod]

Code Review ACK 5b20d46 🥃

[ghost]

@hebasto Can you share any examples that I can try for which GUIUtil::parseBitcoinURI will return false and https://github.com/hebasto/gui/blob/5b20d46f8be6b7fc08012d80a9fc42e9dbc812ff/src/qt/paymentserver.cpp#L254 will be executed ?

[hebasto]

@hebasto Can you share any examples that I can try for which GUIUtil::parseBitcoinURI will return false and https://github.com/hebasto/gui/blob/5b20d46f8be6b7fc08012d80a9fc42e9dbc812ff/src/qt/paymentserver.cpp#L254 will be executed ?

I can't. It looks like this code is never executed due to checks in earlier stages, e.g. in PaymentServer::ipcParseCommandLine.

Closing for now.