Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "qt: Use "fusion" style on macOS Big Sur with old Qt" #246

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 12, 2021

This PR reverts workaround introduced in #177.

After bumping Qt version in depends to 5.12.10 in bitcoin/bitcoin#21376, there are no reasons to use the Fusion style on macOS.

This reverts commit 4e1154d.

After bumping Qt version in depends to 5.12.10 in bitcoin/bitcoin#21376,
there are no reasons to use the Fusion style on macOS.
@hebasto hebasto added the macOS label Mar 12, 2021
@maflcko maflcko added this to the 22.0 milestone Mar 12, 2021
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 77833a3

Verified that 77833a3 is a clean revert of 4e1154d

Copy link

@Talkless Talkless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 77833a3

@leonardojobim
Copy link

tACK 77833a3. Tested on macOS Big Sur v11.2.3

@maflcko maflcko merged commit 8e65320 into bitcoin-core:master Mar 16, 2021
@hebasto hebasto deleted the 210312-revert branch March 16, 2021 08:11
@laanwj
Copy link
Member

laanwj commented Mar 16, 2021

After bumping Qt version in depends to 5.12.10 in bitcoin/bitcoin#21376, there are no reasons to use the Fusion style on macOS.

That is a good reason for reverting it again. Posthumous ACK.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 16, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 28, 2022
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants