Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Overview tab look on Windows #322

Closed
wants to merge 1 commit into from
Closed

Improve Overview tab look on Windows #322

wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 8, 2021

This PR replaces raised frames with plane ones on the Overview tab, and improves its look on Windows.

Fixes #303.

@hebasto hebasto added the UI All about "look and feel" label May 8, 2021
@hebasto hebasto mentioned this pull request May 8, 2021
Closed
@Bosch-0
Copy link

Bosch-0 commented May 10, 2021

Tested this change and the borders on the overview tab indentation is removed but now they have black borders (previously had no border element).

image

I only showed an example of the overview page in that previous issue. This indentation effect seems to be present GUI wide not just the overview page.

@hebasto
Copy link
Member Author

hebasto commented May 10, 2021

Tested this change and the borders on the overview tab indentation is removed but now they have black borders (previously had no border element).

Right. Now it looks the same as on other platforms. If it looks bad, why do not change it for all platforms?

I only showed an example of the overview page in that previous issue. This indentation effect seems to be present GUI wide not just the overview page.

You are right. As a non-designer I'm not able to make conclusions about nicety of a look. But I'm able to (and do) code what were suggested by designers :)

@hebasto
Copy link
Member Author

hebasto commented Jun 2, 2021

Closed in favor of bitcoin/bitcoin#22133.

@hebasto hebasto closed this Jun 2, 2021
@hebasto hebasto deleted the 210508-frame branch June 2, 2021 18:48
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
UI All about "look and feel"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove indented/raised borders elements on Windows
2 participants
@hebasto @Bosch-0