Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mnemonics in menu bar options #408

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

shaavan
Copy link
Contributor

@shaavan shaavan commented Aug 23, 2021

Since #362 we have defaulted to add mnemonic shortcuts for the context menus.
The Window -> Minimize option and File -> Load PSBT from clipboard were hitherto missing a mnemonic shortcut. This PR adds mnemonic shortcuts for them

Changes introduced in this PR:

Master PR
Screenshot from 2021-08-23 23-10-07 Screenshot from 2021-08-23 23-08-41
Screenshot from 2021-08-23 23-10-21 Screenshot from 2021-08-23 23-09-00

The Window -> Minimize an File -> Load PSBT from clipboard options were missing a mnemonic
shortcut. This PR adds mnemonic shortcuts for them.
@jarolrod jarolrod added the UX All about "how to get things done" label Aug 23, 2021
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 7c33e3a

Thanks for fixing this. Tested that there were no shortcut collisions. The added mnemonics shortcuts here work fine.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7c33e3a, tested on Linux Mint 20.2 (Qt 5.12.8).

Also verified that the added shortcuts do not introduce ambiguity.

@hebasto hebasto merged commit d3203a9 into bitcoin-core:master Aug 23, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 23, 2021
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UX All about "how to get things done"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants