Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop macOS ForceActivation workaround #744

Closed

Conversation

fanquake
Copy link
Member

Discussion in bitcoin/bitcoin#16720 seems to point to this being no-longer needed after qt 5.6+.
We now require 5.11.x+.

Discussion in #16720 seems to point to this being no-longer needed after
qt 5.6+. We now required 5.11.x+.
@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 30, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto hebasto changed the title gui: drop macOS ForceActivation workaround Drop macOS ForceActivation workaround Jul 3, 2023
@hebasto
Copy link
Member

hebasto commented Jul 3, 2023

Concept ACK.

We now require 5.11.x+.

When building on macOS, Homebrew provides Qt 5.15.10. Our depends does 5.15.5.

cc @Sjors

@hebasto
Copy link
Member

hebasto commented Jul 3, 2023

I think we can drop -DOBJC_OLD_DISPATCH_PROTOTYPES=0 now. At least, the code compiles for me natively on macOS Ventura (arm64) and when cross-building on Ubuntu 23.04.

@hebasto hebasto added the macOS label Jul 3, 2023
@Sjors
Copy link
Member

Sjors commented Jul 3, 2023

Tested 362e989 but it seems the workaround is still needed.

This was introduced in bitcoin/bitcoin#14123 as a fix to bitcoin/bitcoin#13829.

With this PR, built on macOS 13.4.1 (Intel) with qt@5/5.15.10 via Homebrew, when I use ⌘ + H to hide the window, and then e.g. click on "Receive" in the dock, the window doesn't appear. Without this PR the window does appear.

@fanquake fanquake closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants