Relax GUI freezes during IBD (when using wallets) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't reproduce GUI freezes in the Send dialog during IBD (macOS 10.15.6, fresh data dir and fresh empty wallet on mainnet), but the change looks reasonable to me. |
|
@Sjors: I think you need to be at a height where blocks require more CPU cycles to verify. |
|
I see, in that case |
promag
reviewed
Sep 20, 2020
| @@ -134,7 +136,7 @@ void SendCoinsDialog::setClientModel(ClientModel *_clientModel) | |||
| this->clientModel = _clientModel; | |||
|
|
|||
| if (_clientModel) { | |||
| connect(_clientModel, &ClientModel::numBlocksChanged, this, &SendCoinsDialog::updateSmartFeeLabel); | |||
| connect(_clientModel, &ClientModel::numBlocksChanged, this, &SendCoinsDialog::updateNumberOfBlocks); | |||
There was a problem hiding this comment.
nit, could connect to lambda to avoid changes in header file:
connect(_clientModel, &ClientModel::numBlocksChanged, [this](int, const QDateTime&, double, bool, SynchronizationState sync_state) {
if (sync_state == SynchronizationState::POST_INIT) {
updateSmartFeeLabel();
}
});
|
Concept ACK. |
hebasto
approved these changes
Oct 5, 2020
| @@ -28,6 +28,8 @@ | |||
| #include <wallet/fees.h> | |||
| #include <wallet/wallet.h> | |||
|
|
|||
| #include <validation.h> | |||
There was a problem hiding this comment.
nit: No reasons to create a separate group of headers.
| @@ -98,6 +99,7 @@ private Q_SLOTS: | |||
| void coinControlClipboardLowOutput(); | |||
| void coinControlClipboardChange(); | |||
| void updateFeeSectionControls(); | |||
| void updateNumberOfBlocks(int count, const QDateTime& blockDate, double nVerificationProgress, bool headers, SynchronizationState sync_state); | |||
There was a problem hiding this comment.
nit: updateNumberOfBlocks slot name for an object that knows nothing about "number of blocks" looks a bit weird. But I cannot suggest a better name (
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 16, 2020
…allets) 0d9d2a1 Only update the updateSmartFeeLabel once in sync (Jonas Schnelli) Pull request description: Calling `updateSmartFeeLabel` and therefore `estimateSmartFee` is pointless during IBD. GUI freezes appear because `estimateSmartFee` competes with `processBlock` for the `m_cs_fee_estimator` lock leading to multiple seconds of blocking the GUI thread in `updateSmartFeeLabel`. ACKs for top commit: ryanofsky: Code review ACK 0d9d2a1. Clever fix. Didn't test but I remember I could reproduce the startup issue easily before by putting a sleep in estimateSmartFee. promag: Code review ACK 0d9d2a1. hebasto: ACK 0d9d2a1, tested on Linux Mint 20 (x86_64) with `QT_FATAL_WARNINGS=1` and `-debug=qt`. Tree-SHA512: 85ec2266f06ddd7b523e24d2a462f10ed965d5b4d479005263056f81b7fe49996e1568dafb84658af406e9202ed3bfa846d59c10bb951e0f97cee230e30fafd5
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
stevenroose
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Mar 22, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2021
Summary: > Calling updateSmartFeeLabel and therefore estimateSmartFee is pointless during IBD. > > GUI freezes appear because estimateSmartFee competes with processBlock for the m_cs_fee_estimator lock leading to multiple seconds of blocking the GUI thread in updateSmartFeeLabel. This is a backport of [[bitcoin-core/gui#97 | core-gui#97]] Test Plan: `ninja && src/qt/bitcoin-qt` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10516
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
updateSmartFeeLabeland thereforeestimateSmartFeeis pointless during IBD.GUI freezes appear because
estimateSmartFeecompetes withprocessBlockfor them_cs_fee_estimatorlock leading to multiple seconds of blocking the GUI thread inupdateSmartFeeLabel.