Skip to content

refactor: interfaces, make 'createTransaction' less error-prone

Cirrus CI / lint failed Mar 22, 2024 in 2m 4s

Task Summary

Instruction lint failed in 01:19

Details

✅ 00:03 clone
✅ 00:11 merge_base
✅ 00:01 test_runner
✅ 00:04 python
✅ 00:21 unshallow
❌ 01:19 lint

src/minisketch in HEAD was last updated in commit e9f1d8c27261070d209a28570ad36fe91531cdd2 (tree a749309e1b4edf48091edb57da6de2e8a16498a5)
GOOD
src/secp256k1 in HEAD currently refers to tree 4f5d0a37a5ce94a773267b04af331b5f680b0433
src/secp256k1 in HEAD was last updated in commit 29fde0223abc706925188014209eba75390a9df8 (tree 4f5d0a37a5ce94a773267b04af331b5f680b0433)
GOOD
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux/m4'.
libtoolize: copying file 'build-aux/m4/libtool.m4'
libtoolize: copying file 'build-aux/m4/ltoptions.m4'
libtoolize: copying file 'build-aux/m4/ltsugar.m4'
libtoolize: copying file 'build-aux/m4/ltversion.m4'
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:39: installing 'build-aux/ar-lib'
configure.ac:37: installing 'build-aux/compile'
configure.ac:24: installing 'build-aux/config.guess'
configure.ac:24: installing 'build-aux/config.sub'
configure.ac:27: installing 'build-aux/install-sh'
configure.ac:27: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux/m4'.
libtoolize: copying file 'build-aux/m4/libtool.m4'
libtoolize: copying file 'build-aux/m4/ltoptions.m4'
libtoolize: copying file 'build-aux/m4/ltsugar.m4'
libtoolize: copying file 'build-aux/m4/ltversion.m4'
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:114: installing 'build-aux/compile'
configure.ac:51: installing 'build-aux/config.guess'
configure.ac:51: installing 'build-aux/config.sub'
configure.ac:58: installing 'build-aux/install-sh'
configure.ac:58: installing 'build-aux/missing'
src/Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
Args used        : 210
Args documented  : 222
Args undocumented: 0
set()
Args unknown     : 12
{'-testdatadir', '-zmqpubsequence', '-zmqpubsequencehwm', '-includeconf', '-zmqpubrawtxhwm', '-zmqpubhashblockhwm', '-zmqpubhashtx', '-zmqpubrawtx', '-zmqpubrawblock', '-zmqpubhashtxhwm', '-zmqpubrawblockhwm', '-zmqpubhashblock'}
Success: no issues found in 289 source files
src/wallet/util_spend.h seems to be missing the expected include guard:
  #ifndef BITCOIN_WALLET_UTIL_SPEND_H
  #define BITCOIN_WALLET_UTIL_SPEND_H
  ...
  #endif // BITCOIN_WALLET_UTIL_SPEND_H

^---- failure generated from lint-include-guards.py
src/validation.cpp:5785: neccessary ==> necessary
src/validation.h:278: evalution ==> evaluation, evolution
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt

^---- ⚠️ Failure generated from lint-*.py scripts!
����