Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Murch’s fuzz seed in January 2024 #164

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

murchandamus
Copy link
Contributor

No description provided.

@maflcko
Copy link
Contributor

maflcko commented Jan 3, 2024

lgtm, see also #163 :)

@murchandamus
Copy link
Contributor Author

murchandamus commented Jan 3, 2024

Nice. I did mine just with the regular merge script:

Run mini_miner with args […]/qa-assets/src/test/fuzz/fuzz -rss_limit_mb=8000 -set_cover_merge=1 -shuffle=0 -prefer_small=1 -use_value_profile=0 ../qa-assets/fuzz_seed_corpus/mini_miner ../qa-assets-active-fuzzing/fuzz_seed_corpus/mini_miner

@dergoegge
Copy link
Member

Could you redo the merge on top of #163? (to avoid duplicates)

@murchandamus
Copy link
Contributor Author

Sure, gimme a few hours.

@murchandamus
Copy link
Contributor Author

I rebased on #163 and used @maflcko’s approach:

mv ../qa-assets/fuzz_seed_corpus /tmp/fuzz_inputs_upstream
./test/fuzz/test_runner.py --par $( nproc ) -l DEBUG ../qa-assets/fuzz_seed_corpus/ --m_dir ../qa-assets-active-fuzzing/fuzz_seed_corpus/ -x wallet_notifications -x utxo_total_supply --m_dir /tmp/upstream_fuzz_seed_corpus -x wallet_notifications -x utxo_total_supply
git restore -- ./fuzz_seed_corpus
git add ./fuzz_seed_corpus
git commit -S -m "Add fuzz seeds"

The test_runner script then used -set_cover_merge=1 -shuffle=0 -prefer_small=1 -use_value_profile=0 under the hood.

@maflcko
Copy link
Contributor

maflcko commented Jan 4, 2024

nit: The -x in your command only needs to be specified once. In fact, I doubt it works, given that it should be a comma separated list, according to --help?

@maflcko
Copy link
Contributor

maflcko commented Jan 4, 2024

I guess there is no need to exclude wallet_notifications anymore, since there shouldn't be any timeouts anymore. Only utxo_total_supply (#158) times out for you, right? So the command accidentally did the right thing, even though it was written not entirely correct.

@maflcko
Copy link
Contributor

maflcko commented Jan 4, 2024

lgtm

@dergoegge dergoegge merged commit 0745c86 into bitcoin-core:main Jan 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants