-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Set top-level target output locations #1553
base: master
Are you sure you want to change the base?
Conversation
This change: 1. Collects build artifacts in dedicated locations. 2. Allows to run individual examples with a shared library on Windows. 3. Is compatible with Wine when testing cross-compiled Windows binaries on Linux. 4. Is compatible with integration the project into a larger project hierarchy.
This reverts commit 116d2ab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3779472
It's probably a good idea that the binaries just work without the need to set a PATH. And it's okay to collect all binary artifacts in a single directory, we don't have that many.
What are your commands for building on wine? |
On Ubuntu 24.04 with the
|
While testing #1551, I noticed that when cross-compiling a shared library with examples for Windows, the
ctest
fails to run examples with Wine. Adjusting thePATH
variable insecp256k1/examples/CMakeLists.txt
Lines 16 to 18 in 4af241b
WINEPATH
is expected.Another issue with the current implementation is that the examples cannot run individually on Windows.
This PR resolves both issues by reverting the implementation from #1290 in favour of the reworked and improved implementation from #1233.