Remove the extremely outdated TODO file. #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had two things in it-- tests for the scalar/field code and constant time signing and keygen. The signing and keygen have been thoroughly constant time for years and there are now powerful tests to verify it... no further work on constant-time is needed at least on ordinary platforms (other sidechannels-- sure). The scalar and field code have extensive tests. They could use better static test vectors but they're well tested. TODOs for the project are currently better documented on github right now. This file could return in the future with current info, if needed.
|
ACK 1c32519 |
|
Last updated in 2013 (7b03d83) ACK |
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 28, 2020
Summary: This had two things in it-- tests for the scalar/field code and constant time signing and keygen. The signing and keygen have been thoroughly constant time for years and there are now powerful tests to verify it... no further work on constant-time is needed at least on ordinary platforms (other sidechannels-- sure). The scalar and field code have extensive tests. They could use better static test vectors but they're well tested. TODOs for the project are currently better documented on github right now. This file could return in the future with current info, if needed. This is a backport of secp256k1 [[bitcoin-core/secp256k1#805 | PR805]] Test Plan: \o/ Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7606
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Sep 29, 2020
Summary: This had two things in it-- tests for the scalar/field code and constant time signing and keygen. The signing and keygen have been thoroughly constant time for years and there are now powerful tests to verify it... no further work on constant-time is needed at least on ordinary platforms (other sidechannels-- sure). The scalar and field code have extensive tests. They could use better static test vectors but they're well tested. TODOs for the project are currently better documented on github right now. This file could return in the future with current info, if needed. This is a backport of secp256k1 [[bitcoin-core/secp256k1#805 | PR805]] Test Plan: \o/ Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had two things in it-- tests for the scalar/field code and
constant time signing and keygen.
The signing and keygen have been thoroughly constant time for years
and there are now powerful tests to verify it... no further work
on constant-time is needed at least on ordinary platforms (other
sidechannels-- sure).
The scalar and field code have extensive tests. They could use
better static test vectors but they're well tested.
TODOs for the project are currently better documented on github
right now. This file could return in the future with current
info, if needed.