Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench_ecmult: improve clarity of output #999

Merged
merged 2 commits into from Oct 25, 2021
Merged

bench_ecmult: improve clarity of output #999

merged 2 commits into from Oct 25, 2021

Commits on Oct 24, 2021

  1. bench_ecmult: improve clarity of output 

    Previously "ecmult{,_multi} xg" meant multiplication with (x - 1) random points
and base point G. Now
- ecmult_{,multi_}xp means multiplication with x random points and
- ecmult_{,multi_}xp_g means multiplication with x random points and G
    @jonasnick
    jonasnick committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    96b1ad2 View commit details
    Browse the repository at this point in the history

  2. bench: don't return 1 in have_flag() if argc = 1 

    This makes the semantic of have_flag more clear and fixes a bug
that was introduced in

2fe1b50
Add ecmult_gen, ecmult_const and ecmult to benchmark

where the behavior introduced by this commit was already assumed. If
bench_ecmult was called without arguments, have_flag("simple") returned 1 and no
scratch space was allocated which led to very wrong output.
    @jonasnick
    jonasnick committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    23e2f66 View commit details
    Browse the repository at this point in the history