Remove deprecated std pair wrappers

[jnewbery]

These are deprecated and no longer used in Bitcoin Core.

[ryanofsky]

utACK 4f3d7f4

[jnewbery]

Rebased now that #11 has been merged. @MarcoFalke - do you mind reviewing? Should be trivial.

[jnewbery]

Should be trivially reviewable. Just apply this patch to src/univalue in the bitcoin/bitcoin repo and verify that it still builds.

[maflcko]

utACK 85052a4

[maflcko]

Just noting for completeness, that this would break other downstream projects (if there are any). Effectively we'd have to tag a release before this breaking change and then mark this as a breaking change when tagged a version that includes this change.

Though, it doesn't seem we do proper releases (or tags) at all, so I think this is nothing to worry about.

[Empact]

utACK 85052a4

[jnewbery]

@achow101, @fanquake, @instagibbs, @sipa - this would have prevented the push_back(Pair()) call being introduced that was removed in bitcoin/bitcoin#13927. Since you all reviewed that PR, would you mind taking a look at this? It should be a straightforward review - you can test by applying the change to the univalue subtree in bitcoin and then verifying that the build completes. Thanks!

[maflcko]

Imo this is ready for merge

[achow101]

ACK 85052a4

[fanquake]

utACK 85052a4

[jnewbery]

@laanwj - I think this is ready for merge

[luke-jr]

Uh, NACK?

As @MarcoFalke noted, this breaks the API...

This isn't a Bitcoin Core project. Releases are upstream.

[maflcko]

There is no univalue release with these changes included, so there is nothing broken. We'd only have to "[...] mark this as a breaking change when tagged a version that includes this change."

Note that the subtree bump in the bitcoin core repo is only a "stylistic" change to prevent devs from using the deprecated wrappers. (Sort of a linter)