This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Remove hand-coded UniValue destructor. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the hand-written destructor is removed, the compiler will automatically create a proper one, with correct `noexcept`. This allows `std::vector<UniValue>` to be resized without having to copy all elements first, which makes JSON generation of a bitcoin block (as in the benchmark "BlockToJsonVerbose") 25% faster on my machine.
|
ACK. This is described here: https://en.cppreference.com/w/cpp/language/destructor#Implicitly-declared_destructor Even just for the sake of code clarity, we shouldn't pretend to be smarter than the compiler in writing a destructor. |
|
Unless there are objections, this will be merged by Oct 31st |
|
ACK |
maflcko
pushed a commit
that referenced
this pull request
Oct 30, 2019
b4cdfc4 Remove hand-coded UniValue destructor. (Martin Ankerl) Pull request description: When the hand-written destructor is removed, the compiler will automatically create a proper one, with correct `noexcept`. This allows `std::vector<UniValue>` to be resized without having to copy all elements first, which makes JSON generation of a bitcoin block (as in the benchmark "BlockToJsonVerbose") 25% faster on my machine. Top commit has no ACKs. Tree-SHA512: a4a5a352d946e795b7d78b98b781969caa103acb19770d22d62efd16f42b2845c476dee57df729e983018e065e3b450f3f1e3c95cf68b2f359ee4ca24fba217f
maflcko
pushed a commit
to bitcoin/bitcoin
that referenced
this pull request
Nov 1, 2019
fa0b3da Squashed 'src/univalue/' changes from 7890db9..5a58a46 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e8 laanwj: ACK fa439e8 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 1, 2019
fa0b3da Squashed 'src/univalue/' changes from 7890db9..5a58a46 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e8 laanwj: ACK fa439e8 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
wqking
added a commit
to wqking-misc/Phore
that referenced
this pull request
Dec 22, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 14, 2020
fa0b3da Squashed 'src/univalue/' changes from 7890db9..5a58a46 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e8 laanwj: ACK fa439e8 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 14, 2020
fa0b3da Squashed 'src/univalue/' changes from 7890db9..5a58a46 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e8 laanwj: ACK fa439e8 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
fa0b3da Squashed 'src/univalue/' changes from 7890db9..5a58a46 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e8 laanwj: ACK fa439e8 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
malbit
pushed a commit
to malbit/raptoreum
that referenced
this pull request
Nov 5, 2021
fa0b3da36cd7cf0aada22f2d459296b81274c2f9 Squashed 'src/univalue/' changes from 7890db99d6..5a58a46671 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e88af944082875e1fdb1cd8bb5a74b88b56 laanwj: ACK fa439e88af944082875e1fdb1cd8bb5a74b88b56 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 5, 2022
fa0b3da Squashed 'src/univalue/' changes from 7890db9..5a58a46 (MarcoFalke) Pull request description: Only change is a performance improvement. See bitcoin-core/univalue-subtree#21 (comment) and bitcoin-core/univalue-subtree#15 (comment) ACKs for top commit: jnewbery: ACK fa439e8 laanwj: ACK fa439e8 Tree-SHA512: 35ea8f76ea4806182949c8eb5a8b652d1aaeec03ee023838e7cb29abcb81c61d59b38f15708564a78574722df57d13f61ef17d0f670a4056819705ef892321e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the hand-written destructor is removed, the compiler will automatically create a proper one, with correct
noexcept. This allowsstd::vector<UniValue>to be resized without having to copy all elements first, which makes JSON generation of a bitcoin block (as in the benchmark "BlockToJsonVerbose") 25% faster on my machine.