sort import to make ruff happy #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. The change is correct, but I feel like it's highlighting that something in our CI is off; for example the PR I merged was passing and this one is failing, which is the inverse of what should be happening... Just trying to figure out why. |
|
I'm wondering now if we need these lines in the ruff checkout step too. Alternatively we could extract Ruff into its own workflow and have it run on |
|
Going to merge this for now, and fix properly later. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Current CI is failing because ruff is unhappy that some of our imports are unsorted.
Solution
Perform a
ruff --fixto sort the imports.