-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coldcard Q #4180
base: master
Are you sure you want to change the base?
Add Coldcard Q #4180
Conversation
Thanks for the submission! What's the current status of the Coldcard Q?
|
Thanks for starting the review.
Already shipping and thousands of units already shipped out. Due to higher demand than anticipated we haven't switched from reservation mode in the store just to manage the inflow. Hopefully in a few weeks should be switched.
It's very similar to Mk line, being slowly improved and more features added. They share the same firmware and architecture with the extra hardware capabilities. (more already there since this thread started)
We've had units commercially out for over 3 months now, with test units out for many months.
Thanks for noticing, although it is reproducible we didn’t have the tags there when you first reviewed, they were subsequently added https://github.com/Coldcard/firmware/tags As a note we have already merged the Q & Mk branches into master as they are the same code base with different hardware targets. |
In regards to the documentation, let me be clear that there aren't any specific listing criteria relating to documentation, so these are just some observations.
Given the fact that thousands of units have been shipped out, I'm surprised to find no mention of the device in any of the Getting Started guides listed on the website printed on the box. As a "new user", the guides I was referred to told me to plug in the USB and it would power up. It didn't. I was concerned the device was faulty, so I put in batteries. It would have been nice to have had suggestions or requirements relating to the batteries (alkaline, lithium, NiMH). I looked for a power button and pressed it and the screen didn't come on. Now I was really concerned the device was faulty. It turns out I didn't press the power button long enough. After some more fumbling it came on. All of this could have been avoided by trivial updates to the existing documentation. Likewise, given the fact that one of the major new features is the QR scanner, it was disappointing to note that Coldcard Q is actually not QR compatible with most of the wallets listed on the Compatible Wallets page. Scanning transactions displays the text "Above is text that was scanned. We can't do any more with it." I believe that even the most minimal amount of guidance for new users could eliminate a lot of confusion and frustration. |
Thanks for the feedback Craig.
nice example of third party video by Unchained https://x.com/unchainedcom/status/1786397489676845243 |
What is the official release date that should be used in the review? |
We never really announced it, just started shipping. I think we can use Feb 8th 2024 as it was likely the most we talked about shipping public. |
I have reviewed the Coinkite Coldcard Q wallet based on the current wallet requirements criteria and my evaluation is below. The summary is that the wallet passes on security and overall design, however because the HSTS preload directive is missing on the website, I cannot at this time recommend it for listing. I will be glad to recommend Coldcard Q for listing once this website issue is resolved. I try not to editorialize on issues not specifically related to the listing criteria, and there are no criteria related to QR code support, but it is hard not to comment on a device that was seemingly named for its QR code support. I have to say that I am personally fairly disappointed at the lack of support in Coldcard Q for existing QR standards such that the currently stated compatibility includes only two wallets which support the Coldcard Q's new format. In addition, Coldcard Q failed a multisig QR code configuration import during the review (since reported and fixed) with the one supported wallet I was testing with. Note that as a "hardware wallet," only the hardware and firmware components of the device were evaluated. Wallet software that runs externally to the Coldcard Q device was not evaluated in this review. Sparrow Wallet was used during this review, but not evaluated. I concur with the scoring in 1111efd. Historically wallets that have been released less than six months ago receive the transparency score Coldcard QFirmware v1.2.0QReview Version 2024062401The wallet list is based on the personal evaluation of the maintainer(s) and These requirements are meant to be updated and strengthened over time. NOTE The hardware device used for testing was provided by Coinkite at no cost. NOTE Only the hardware/firmware is being evaluated here. Wallet software running external to the device is not being reviewed. Basic requirements:
Optional criteria (some could become requirements):
|
Adds Coldcard Q to the list of hardware wallets.