Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of adding new foreign keys to the SpendingInfo Table #1275

Closed
benthecarman opened this issue Mar 27, 2020 · 1 comment · Fixed by #1562
Closed

Handling of adding new foreign keys to the SpendingInfo Table #1275

benthecarman opened this issue Mar 27, 2020 · 1 comment · Fixed by #1562
Labels
database database related work for our various projects

Comments

@benthecarman
Copy link
Collaborator

In #1197 we are adding a foreign key to the SpendingInfo table that will cause old spending infos to be invalid for not having a record for it's foreign key. The best way to handle this is would be to do a rescan on start up if there is a foreign key error on the table. However, a rescan can be expensive and time consuming. If you have other ideas how best ways to handle this and similar issues in the future, please share.

@benthecarman benthecarman added the database database related work for our various projects label Mar 27, 2020
@Christewart
Copy link
Contributor

Christewart commented Mar 30, 2020

I am definitely in the camp of just rescanning with a sane timestamp set by default, for instance 2019-06-01 to tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database database related work for our various projects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants