Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescan when UTXOs don't have associated transactions #1562

Merged
merged 4 commits into from Jun 25, 2020

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Jun 15, 2020

Fixes #1558
Fixes #1275

Downloading the block should be sufficient here because we will process every tx in the block and any tx relevant to us should be added to our transaction database.

@benthecarman benthecarman added the wallet work for the wallet project label Jun 15, 2020
@benthecarman benthecarman added this to the v0.4.0 milestone Jun 15, 2020
@Christewart
Copy link
Contributor

Now that #1598 is in, can we move this stuff into the WalletAppConfig.start()? I don't think this should be in Wallet.scala, are we keeping this around for the long term?

@benthecarman benthecarman force-pushed the rescan-missing-utxos branch 2 times, most recently from e6e61af to 2432d9b Compare June 24, 2020 22:21
@Christewart
Copy link
Contributor

Also now fixes #1559

@Christewart Christewart merged commit 021e21d into bitcoin-s:master Jun 25, 2020
@benthecarman benthecarman deleted the rescan-missing-utxos branch October 25, 2020 19:31
Christewart pushed a commit that referenced this pull request May 1, 2021
* Rescan for missing utxos

* Move to Wallet.start

* Start and stop wallet threads with wallet

* Fix warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet work for the wallet project
Projects
None yet
3 participants