Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI commands for current wallet apis #1291

Merged
merged 1 commit into from Apr 3, 2020
Merged

Add CLI commands for current wallet apis #1291

merged 1 commit into from Apr 3, 2020

Conversation

benthecarman
Copy link
Collaborator

Related to #1284

Adds

  • separate calls for confirmed and unconfirmed balance
  • getUTXOs
  • getAddresses
  • getAccounts
  • isEmpty
  • getAddressInfo
  • getNewAccount

@benthecarman benthecarman added wallet work for the wallet project cli labels Apr 1, 2020
@benthecarman benthecarman added this to the v0.4.0 milestone Apr 1, 2020
@Christewart Christewart mentioned this pull request Apr 2, 2020
Closed
@Christewart Christewart added this to In progress in v0.4.0 Apr 2, 2020
nkohen
nkohen approved these changes Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@nkohen nkohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Christewart Christewart merged commit c7a350d into bitcoin-s:master Apr 3, 2020
@benthecarman benthecarman deleted the wallet-api-to-routes branch April 3, 2020 22:29
@Christewart Christewart moved this from In progress to Done in v0.4.0 Apr 13, 2020
Christewart pushed a commit that referenced this pull request May 1, 2021
@benthecarman
Add CLI commands for current wallet apis (#1291)
efec79b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christewart Christewart Christewart approved these changes

@nkohen nkohen nkohen approved these changes

Assignees
No one assigned
Labels
cli wallet work for the wallet project
Projects
No open projects
v0.4.0
  
Done
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benthecarman @Christewart @nkohen