Use FutureUtil.foldLeftAsync() to process messages we parsed on the p… #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2p network. This moves the blocking with Await.result() from inside of each message we process, to after the entire batch of messages is processed
benthecarman
approved these changes
Apr 9, 2020
Christewart
added a commit
that referenced
this pull request
May 1, 2021
…2p network. This moves the blocking with Await.result() from inside of each message we process, to after the entire batch of messages is processed (#1326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…2p network. This moves the blocking with Await.result() from inside of each message we process, to after the entire batch of messages is processed
I don't think this will have much performance improvement. It is a cleaner refactor, and a stepping stone to figuring out how to solve #672