Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using java try catch rather than wrapping in a scala.util.Try #1334

Merged
merged 1 commit into from Apr 13, 2020
Merged

Try using java try catch rather than wrapping in a scala.util.Try #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions bitcoind-rpc/src/main/scala/org/bitcoins/rpc/client/common/Client.scala
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@ import org.bitcoins.rpc.config.BitcoindAuthCredentials.CookieBased
import org.bitcoins.rpc.config.BitcoindAuthCredentials.PasswordBased
import java.nio.file.Path

import com.fasterxml.jackson.core.JsonParseException
import org.bitcoins.commons.jsonmodels.bitcoind.RpcOpts
import org.bitcoins.rpc.config.BitcoindAuthCredentials
import org.bitcoins.rpc.BitcoindException
Expand Down Expand Up @@ -196,6 +197,9 @@ trait Client extends BitcoinSLogger with StartStop[BitcoindRpcClient] {
case exc: StreamTcpException
if exc.getMessage.contains("Connection refused") =>
false
case _: JsonParseException =>
//see https://github.com/bitcoin-s/bitcoin-s/issues/527
false
}
}

Expand Down