Implemented (lax) signature parsing in Bitcoin-S #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkohen
added
refactor
dependencies
…rsion to most recent
…now! Deleted C-like version in place of this one after property based tests showed them to be equivalent
nkohen
force-pushed
the
bouncy-castle-upadate
branch
from
650aaee
to
2ea9ffc
Compare
| @@ -235,6 +205,108 @@ sealed abstract class DERSignatureUtil { | |||
| require(DERSignatureUtil.isLowS(sigLowS)) | |||
| sigLowS | |||
| } | |||
|
|
|||
| /** Scala implementation of https://github.com/bitcoin/bitcoin/blob/master/src/pubkey.cpp#L16-L165 | |||
There was a problem hiding this comment.
nit: instead of using master, use the current HEAD commit so if there are changes it doesn't make this comment outdated
Christewart
reviewed
May 20, 2020
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* Implemented parseDERLax signature parsing and bumped bouncy castle version to most recent * implemented using iterators * Factored out common functionality and added comments, it is readable now! Deleted C-like version in place of this one after property based tests showed them to be equivalent * Made compatible with scala 2.12 * Make compatible with scala 2.11 * Added tests for lax DER signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to finally update bouncy castle!
The current version is literally just me mimicking (
vars,Arrays and all) the code here line for line: https://github.com/bitcoin/bitcoin/blob/master/src/pubkey.cpp#L16-L165I will attempt to clean this up and scala-fy it tomorrow, though I've already attempted it once and tbh I don't fully understand the business with the first bit of length bytes (I know it has to do with leading zeroes appended to r and s values, but need to get a better grasp on this), which makes it quite hard to re-write.
That said, at the time I did not actually have a working integration and now that I do it should be easier to write a new function that (should do) does the same thing and compare.
I still haven't been able to access the Gemini fork and see what is going on over there but hopefully this can help on their end!
EDIT:
I have now implemented it in a clean and readable way that is still efficient using iterators!