Db conf on pr 1877 #1879
Merged
Db conf on pr 1877 #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' test trait, clean up P2PClientTest
Christewart
force-pushed
the
db_conf_on_pr_1877
branch
from
115c41c
to
a728d93
Compare
Christewart
added a commit
that referenced
this pull request
May 1, 2021
* Extend StartStopAsync with BitcoinSAppConfig, create 'CachedAppConfig' test trait, clean up P2PClientTest * Start cleaning up after ourselves in the chainTest test suite * Call .stop() for appConfig's spun up in ChainAppConfigTest * Database configuration defaults * increase number of Postgres connections * add more logging * close connections pools in tests * update afterAll() * Fix conflict Co-authored-by: rorp <rorp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #1844 onto #1877 to see if anything things gets fixed.
I still expect to see failures on the wallet project as I haven't addressed any fixture cleanup there, but hopefully 🤞 this fixes the chain and node project for postgres