Fix maxBy() exception in the case of empty Blockchain in ChainHandler… #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….bestFilterHeaderSearch()
benthecarman
approved these changes
Aug 29, 2020
Christewart
added a commit
that referenced
this pull request
May 1, 2021
#1934) * Fix maxBy() exception in the case of empty Blockchain in ChainHandler.bestFilterHeaderSearch() * Add another unit test to CompactFilterHeaderDAO for coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….bestFilterHeaderSearch()
This was introduced in #1926
The use of
maxBy()is tricky in the Scala standard library, as it throws an exception if theVectoris empty. This PR adds a guard for the case that we are syncing a new node from scratch, we will have zero filter headers in the database. Previously we would fail with athrow new UnsupportedOperationException("empty.maxBy")