Bech32 address improvements #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
bech32-improvements
branch
from
ea676d0
to
4ae3f6b
Compare
Merged
Christewart
requested changes
Jan 27, 2021
| @@ -305,6 +305,17 @@ object Bech32 extends Bech32 { | |||
| val charset: Vector[Char] = Vector('q', 'p', 'z', 'r', 'y', '9', 'x', '8', | |||
| 'g', 'f', '2', 't', 'v', 'd', 'w', '0', 's', '3', 'j', 'n', '5', '4', 'k', | |||
| 'h', 'c', 'e', '6', 'm', 'u', 'a', '7', 'l') | |||
|
|
|||
| /** The Bech32 character set for decoding. */ | |||
There was a problem hiding this comment.
is there a reference to this? Is it reversed or the inverse?
There was a problem hiding this comment.
Added link from where I got it from
Christewart
approved these changes
Jan 27, 2021
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* Bech32 address improvements * Respond to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes so we can read uppercase addresses, adds some decoding optimizations, and makes sure we verify the checksum of the address.