Set fetch-depth to 500 so we don't take forever to clone repo on ci #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
approved these changes
Feb 19, 2021
Christewart
changed the title
This was referenced Feb 20, 2021
Christewart
added a commit
that referenced
this pull request
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this may be the culprit for some slow release times on CI. The latest publish took 19 minutes, and i've seen them take upwards of 40 minutes.
Here is the description for
fetch-depthAs talked about in #2674 a full
git clonewith our repo currently takes 8 minutes on my machine (!)I believe this also is slowly down builds on CI.
This PR does this, but it does come with a tradeoff. If we don't fetch deep enough (specifically to our last official tag) we won't get correct versioning. I experienced this on #2684 and ended up with weird versions on docker hub that look like this
0.0.0-1-a24e2278-SNAPSHOT
note that we don't have the latest tag (
0.5.0) so we revert to the default git tag (0.0.0). So we need to make sure strike a balance here.