Put tests for bitcoind-rpc and eclair-rpc into a separate project to … #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get rid of circular dependency
Christewart
added a commit
that referenced
this pull request
May 1, 2021
#341) * Put tests for bitcoind-rpc and eclair-rpc into a separate project to get rid of circular dependency * Modify travis yml file to get rid of all testkit stuff * rename rpc project to bitcoind-rpc project * Add bitcoind-rpc test cases that got deleted accidentally * Add more files missing from bitcoind-rpc-test * Remove circular deps part on CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327
…get rid of circular dependency
The basic idea is breaking up tests into their own project for
bitcoind-rpcandeclair-rpc. This allows us to break the circular dependencyNow:
bitcoind-rpc-testdepends ontestkitwhich depends onbitcoind-rpcand
eclair-rpc-testdepends ontestkitwhich depends oneclair-rpc.There is also some other configuration stuff changed in this PR, like adding a
.jvmoptsfile with default configurations for the jvm. This PR seems to increase memory usage on the JVM for some reason.