Implement bitcoind v23 rpc #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solo1g
force-pushed
the
v23rpc
branch
3 times, most recently
from
a51132c
to
fd175e2
Compare
Christewart
reviewed
Jun 6, 2022
bitcoind-rpc/src/main/scala/org/bitcoins/rpc/client/common/BitcoindRpcClient.scala
Show resolved
Hide resolved
|
Squashed the rerun commits. Seems like the issue got fixed with the recent changes. |
Christewart
reviewed
Jun 21, 2022
| else if (Properties.isMac) ("osx64", "tar.gz") | ||
| else if (Properties.isMac) | ||
| version match { | ||
| case "23.0" => ("x86_64-apple-darwin", "tar.gz") |
Christewart
approved these changes
Jun 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4292
v23 release notes for reference: https://lists.linuxfoundation.org/pipermail/bitcoin-core-dev/2022-April/000111.html