Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetch compact filters in NeutrinoNode.sync() before fetching block headers / compact filter headers #5023

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

Christewart
Copy link
Contributor

@Christewart Christewart commented Mar 23, 2023

Likely related to #5022

This was included in #4408 for some reason but i'm unsure why. It doesn't seem to make sense to me in any situation that we fetch compact filters before block headers / filter headers.

@Christewart Christewart added bug node work for the node project labels Mar 23, 2023
@Christewart Christewart added this to the 2.0 milestone Mar 23, 2023
@Christewart Christewart merged commit 1d611ec into bitcoin-s:master Mar 23, 2023
@Christewart Christewart modified the milestones: 2.0, 1.9.8 Aug 23, 2023
@Christewart Christewart added this to Done in 1.9.8 Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug node work for the node project
Projects
No open projects
1.9.8
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant