Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 01 11 bip68 bip112 txversion bug #5346

Merged

Conversation

Christewart
Copy link
Contributor

Fixes bug in the LocktimeInterpreter where we weren't converting the transaction version from Int32 -> UInt32 as stated in BIP68 and 112.

Screenshot 2024-01-11 at 5 01 43 PM

@Christewart Christewart added bug core work for the core project labels Jan 11, 2024
@Christewart Christewart added this to the 1.9.8 milestone Jan 11, 2024
@Christewart Christewart marked this pull request as ready for review January 12, 2024 12:43
@Christewart Christewart merged commit 421970d into bitcoin-s:master Jan 12, 2024
11 checks passed
@Christewart Christewart added this to Done in 1.9.8 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core work for the core project
Projects
No open projects
1.9.8
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant