WIP: Initial BIP157 support #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelrogstad
added
node
torkelrogstad
force-pushed
the
2019-08-01-bip157
branch
from
2392377
to
80fe70a
Compare
nkohen
reviewed
Aug 5, 2019
| logger.error(s"Exiting") | ||
| sys.error(message.toString()) | ||
| // we might want to log the stack trace if message is an error | ||
| val (processedMessage: Any, stackTrace: Option[Array[StackTraceElement]]) = |
| maybeBoxed.getCause() match { | ||
| case null => (maybeBoxed, None) | ||
| case err: NotImplementedError => (err, Some(err.getStackTrace())) | ||
| case other: Throwable => (other, None) |
There was a problem hiding this comment.
Do other and maybeBoxed in the null case not have a getStackTrace member?
| /** | ||
| * Filter types for BIP157 block content filters | ||
| * | ||
| * @see [[https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki#block-filters BIP158]] |
There was a problem hiding this comment.
nit: I believe the comment should reference 158
| def apply( | ||
| blockHash: DoubleSha256Digest, | ||
| filter: GolombFilter): CompactFilterMessage = { | ||
| val filterBytes = filter.bytes |
There was a problem hiding this comment.
Double-check that this doesn't already include the CompactSizeUInt, I forget whether or not it does
| filterType: FilterType, | ||
| stopHash: DoubleSha256Digest, | ||
| previousFilterHeader: DoubleSha256Digest, | ||
| filterHashes: Vector[DoubleSha256Digest]) |
There was a problem hiding this comment.
You should create a more specific type RawFilterHeader that wraps a DoubleSha256Digest (and have FilterHeader::hash return one of these)
| @@ -82,7 +95,7 @@ sealed abstract class ServiceIdentifier extends NetworkElement { | |||
| val innerText = | |||
| if (nodeNone) "none" | |||
| else | |||
| s"network=$nodeNetwork, getUtxo=$nodeGetUtxo, bloom=$nodeBloom, witness=$nodeWitness, xthin=$nodeXthin, networkLimited=$nodeNetworkLimited" | |||
| s"network=$nodeNetwork, compactFilters=$nodeCompactFilters getUtxo=$nodeGetUtxo, bloom=$nodeBloom, witness=$nodeWitness, xthin=$nodeXthin, networkLimited=$nodeNetworkLimited" | |||
| @@ -143,6 +156,8 @@ object ServiceIdentifier extends Factory[ServiceIdentifier] { | |||
| */ | |||
| val NODE_XTHIN: ServiceIdentifier = ServiceIdentifier(1 << 4) | |||
|
|
|||
| val NODE_COMPACT_FILTERS = ServiceIdentifier(1 << 6) | |||
| val (hashes, remainingBytes) = loop(Vector.empty, filterHashesBytes) | ||
|
|
||
| assert(hashes.length == filterHashesLength.toInt) | ||
| assert(remainingBytes.isEmpty) |
There was a problem hiding this comment.
nit: Is it nicer to use require with error messages?
| import org.bitcoins.core.p2p.GetCompactFilterHeadersMessage | ||
| import scodec.bits.ByteVector | ||
|
|
||
| object RawGetcompactFilterHeadersMessageSerializer |
| @@ -37,6 +46,24 @@ class DataMessageHandler(callbacks: SpvNodeCallbacks, chainHandler: ChainApi)( | |||
| peerMsgSender: PeerMessageSender): Future[Unit] = { | |||
|
|
|||
| payload match { | |||
| case checkpoint: CompactFilterCheckPointMessage => | |||
|
This was closed in favor of #695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
To test this PR/do dev work on BIP157 you need to compile Jimpo's fork of Core, PR/branch is here: bitcoin/bitcoin#16442
TODO:
getcfheadersandcfheadersmessages