Signer UTXOSpendingInfo refactor #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit can be ignored as it is #798 |
This was referenced Oct 24, 2019
Merged
Christewart
reviewed
Oct 25, 2019
Christewart
reviewed
Oct 25, 2019
Fixed all the broken things Replaced TxSigComponent with unsigned Transaction in Signer interface to remove illegal states
nkohen
force-pushed
the
signer_spending_info_refactor
branch
from
9cf7846
to
c08fed5
Compare
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* Refactored Signer interface to use TxSigComponent and UTXOSpendingInfo Fixed all the broken things Replaced TxSigComponent with unsigned Transaction in Signer interface to remove illegal states * Added p2sh throw case in Signer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all the parameters to
Signer.signwith just aUTXOSpendingInfo,TxSigComponent, and aScriptPubKey. This gets rid of the need forOverridesForNestedSigningand theOptions involved there. It also makes things more extensible since in the futureUTXOSpendingInfowill be a much nicer ADT and will allow us to pass which condition is being signed with on ConditionalSigner and such.Replaces #828