scalafmt On Compile #940
Merged
scalafmt On Compile #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
fmtoncomp
branch
from
f275848
to
5bf8a97
Compare
benthecarman
force-pushed
the
fmtoncomp
branch
3 times, most recently
from
64d7db7
to
3da067a
Compare
Christewart
reviewed
Jun 22, 2020
.travis.yml
Outdated
| @@ -8,62 +8,71 @@ jobs: | |||
| os: linux | |||
| name: "Compile & Formatting Check" | |||
| env: | |||
| - CI="1" | |||
There was a problem hiding this comment.
@nkohen thought this was setup for the whole environment? Can't we configure these to be matrix wide?
There was a problem hiding this comment.
Looks like CI is set to true automatically for us, fixed to use this.
https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
benthecarman
force-pushed
the
fmtoncomp
branch
2 times, most recently
from
6c82713
to
ed769da
Compare
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* scalafmt On Compile * Disable scalafmtOnCompile for all CI runs * Make CI use travis default CI var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.