Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Fee wizard in Preferences #154

Closed
jim618 opened this issue Jul 20, 2014 · 8 comments
Closed

Create Fee wizard in Preferences #154

jim618 opened this issue Jul 20, 2014 · 8 comments
Assignees
Milestone

Comments

@jim618
Copy link
Contributor

jim618 commented Jul 20, 2014

Fees tab
Miners' fee
The current miners' fee is 1,000 satoshis per kB.

You can increase this fee which might get your transaction into a block faster
Slider 1,000 to 10,000 with intervals of 1,000 satoshis.

Client fee
The current client fee is 1,000 satoshis per transaction sent.
You currently owe XXX. Payable in Y sends.

  • Ability to overpay BRIT if you like to avoid privacy issues.
@jim618 jim618 added this to the Release 0.1 milestone Jul 20, 2014
@gary-rowe gary-rowe modified the milestones: Release 0.1, Public beta Nov 23, 2014
@gary-rowe gary-rowe changed the title Create Fee tab in preferences Create Fee wizard in Preferences Nov 24, 2014
@gary-rowe gary-rowe modified the milestones: Release 0.1 Payment Protocol, Beta 7 Feb 13, 2015
@gary-rowe gary-rowe self-assigned this Feb 13, 2015
@ghost
Copy link

ghost commented Feb 13, 2015

Add the MultiBit donation address always to the list of BRIT addresses.
Add a panel to the Fee Preferences screen/ wizard making it easy for users to donate, explaining fees up to the donation amount are waived

@gary-rowe gary-rowe assigned jim618 and unassigned gary-rowe Feb 19, 2015
jim618 added a commit that referenced this issue Feb 22, 2015
jim618 added a commit that referenced this issue Feb 22, 2015
@jim618
Copy link
Contributor Author

jim618 commented Feb 22, 2015

This is working but still needs some code refactoring and FEST tests.
Screenshot:

Edit:Removed as out of date.

@gary-rowe
Copy link
Contributor

Looking good! Will need the supporting text to explain the effect of moving the slider around and a summary of the client fees.

@jim618
Copy link
Contributor Author

jim618 commented Feb 23, 2015

Updated screenshot with more explanatory help and a donate button (that fills out the Send screen directly for the user):

screen shot 2015-02-23 at 12 12 17

@gary-rowe
Copy link
Contributor

Looking good. Some UI suggestions:

  • include the outstanding client fee balance and when it comes due (replicate the Send confirmation panel info) since this is essentially a dashboard view
  • Change "Default" to 1000sat since we know that is sensible (perhaps start from 500sat?)
  • Consider making the "Donate now" button an actual Wizard button so it appears on the bottom row next to Apply - it would be more pleasing to the eye and may be more likely to get a "curiosity" click.
  • The "Donate now" button could also have reduced text "Donate" and probably won't need an ellipsis since users will expect the chance to cancel out of the send process.

jim618 added a commit that referenced this issue Feb 23, 2015
@jim618
Copy link
Contributor Author

jim618 commented Feb 23, 2015

I've finished off this issue with:

  • some layout tweaks
  • refactored out a Sliders factory class
  • two FEST tests to check the slider and the donate button

Ready for review and closing

@gary-rowe
Copy link
Contributor

Verified working. I think we need a discussion about the default values since 3000sat seems too high to me. However that discussion is not a blocker for the issue so closing.

@jim618
Copy link
Contributor Author

jim618 commented Feb 23, 2015

RE: the default - I suggest we try it out in real life during Beta 7 and set it accordingly.

It may well change from release to release as the fee structure changes.
The lower and upper limits may well change too.

I have put in a 'normaliser' so that the value used is always between the lower and upper limits so we can tweak the value going forward as the fee structure for Bitcoin transactions changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants