Support cookie-based RPC authentication (Bitcoin Core) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A constant `RPC_CREDENTIALS` is introduced that determines the RPC authentication method: if credentials are set (i.e. 'Some(user, pass)'), user-pass-authentication is used, otherwise (i.e. 'None'), authentication is cookie-based (available since Bitcoin Core v0.12). Of course, in the future the constant will change to a variable that is assigned by the return value of a function that reads a configuration file. Note that by now the cookie-file is assumed to reside in ~/.bitcoin/regtest/.cookie and thus this authentication method will only work for Linux and regtest network by now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards supporting cookie-based RPC authentication, as offered by Bitcoin Core since v0.12.
A constant
RPC_CREDENTIALSis introduced that determines the RPC authentication method: if credentials are set (i.e.Some(user, pass)), user-pass-authentication is used, otherwise (i.e.None), authentication is cookie-based.Note that by now the cookie-file is assumed to reside in
~/.bitcoin/regtest/.cookieand thus this authentication method will only work for Linux (also *BSD I guess?) and regtest network. Tested successfully with Debian 10 and Bitcoin Core 0.21.0.If this PR gets accepted, there are a few possible follow-ups I could think of:
RPC_CREDENTIALS(and probably other constants) in a separate source file to avoid conflicts during development if changes in main.rs are done and cookie-base auth is used (short-term)README.md