Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hash160 for strongly typed arguments #33

Merged
merged 1 commit into from Aug 19, 2021

Conversation

GeneFerneau
Copy link
Contributor

Use bitcoin::hashes::hash160::Hash in place of [u8; 20] for strongly typed arguments across the code base.

Use `bitcoin::hashes::hash160::Hash` in place of `[u8; 20]` for strongly
typed arguments across the code base.
@codecov-commenter
Copy link

Codecov Report

Merging #33 (1f93217) into master (b67dab5) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   80.89%   80.86%   -0.04%     
==========================================
  Files           8        8              
  Lines        2586     2587       +1     
==========================================
  Hits         2092     2092              
- Misses        494      495       +1     
Impacted Files Coverage Δ
src/wallet_sync.rs 78.45% <0.00%> (ø)
src/contracts.rs 92.01% <100.00%> (-0.21%) ⬇️
src/maker_protocol.rs 80.77% <100.00%> (ø)
src/messages.rs 86.90% <100.00%> (ø)
src/taker_protocol.rs 95.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67dab5...1f93217. Read the comment docs.

Copy link
Contributor

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong concept with review ACK.

We should try to move away from raw data wherever possible.

@chris-belcher chris-belcher merged commit 1d9b34b into bitcoin-teleport:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants