Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdk::Wallet should have context-specific error types #994

Closed
Tracked by #76
evanlinjin opened this issue May 26, 2023 · 3 comments · Fixed by #1028
Closed
Tracked by #76

bdk::Wallet should have context-specific error types #994

evanlinjin opened this issue May 26, 2023 · 3 comments · Fixed by #1028
Assignees
Milestone

Comments

@evanlinjin
Copy link
Member

          I agree that the errors aren't great.

However, I disagree about having a single error enum with a large number of variants. I think we should fix errors in one go with a separate PR, otherwise it's duplicate work.

Originally posted by @evanlinjin in #976 (comment)

@LLFourn
Copy link
Contributor

LLFourn commented May 28, 2023

I think the bdk::Error enum should go but I don't know when that can happen. I'd probably put it last on the list of things needing to be done. All new fallible functions should have their own error type.

@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.1 milestone May 30, 2023
@notmandatory
Copy link
Member

Moving this to milestone alpha.4 where we're going to focus on Wallet APIs.

@nondiremanuel
Copy link

As per what we said during the last Lib Team Call, the fix for this should be into #1028 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants