Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default-features = false for rust-bitcoin and rust-miniscript #882

Merged
merged 1 commit into from Mar 8, 2023
Merged

Set default-features = false for rust-bitcoin and rust-miniscript #882

merged 1 commit into from Mar 8, 2023

Conversation

benthecarman
Copy link
Contributor

Same as bitcoindevkit/rust-esplora-client#39

Should let bdk be unbiased for things like no-std

@benthecarman
Copy link
Contributor Author

benthecarman commented Mar 4, 2023 •
edited

Looks like I'll need #877 first

@benthecarman benthecarman force-pushed the bitcoin-default-features branch 4 times, most recently from 12d8886 to fad3e7d Compare March 5, 2023 01:39
@benthecarman benthecarman changed the title Set default-features = false for rust-bitcoin Set default-features = false for rust-bitcoin and rust-miniscript Mar 5, 2023
@notmandatory
Copy link
Member

We're currently holding off merges to the master branch in preparation for #793. Can you rebase this PR to be against the release/0.27 branch? Then it can go out with our next bugfix 0.27.2 release.

@benthecarman benthecarman changed the base branch from master to release/0.27 March 7, 2023 09:48
@benthecarman
Copy link
Contributor Author

We're currently holding off merges to the master branch in preparation for #793. Can you rebase this PR to be against the release/0.27 branch? Then it can go out with our next bugfix 0.27.2 release.

Done, still needs #877

@notmandatory
Copy link
Member

Done, still needs #877

Thanks, I just merged #877, ready for a final rebase.

@benthecarman
Copy link
Contributor Author

Done!

notmandatory
notmandatory approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 87c558c

@notmandatory notmandatory merged commit 87c558c into bitcoindevkit:release/0.27 Mar 8, 2023
43 checks passed
This was referenced Mar 15, 2023
Closed
Closed
@evanlinjin evanlinjin mentioned this pull request Mar 16, 2023
Merged
3 tasks
@notmandatory notmandatory mentioned this pull request Mar 16, 2023
Closed
3 tasks
@notmandatory notmandatory modified the milestones: 0.27.2, 0.28.0 Mar 28, 2023
@notmandatory notmandatory mentioned this pull request Apr 11, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@benthecarman benthecarman

Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benthecarman @notmandatory