WalletFiles: don't delete temp file if rename failed. It might be the…

… only copy of the wallet we have! Only really should affect Windows.
bitcoinj · May 5, 2014 · 0e74eba · 0e74eba
1 parent fbbdbb5
commit 0e74eba
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/core/src/main/java/com/google/bitcoin/core/Wallet.java b/core/src/main/java/com/google/bitcoin/core/Wallet.java
@@ -312,7 +312,8 @@ public void saveToFile(File temp, File destFile) throws IOException {
             if (Utils.isWindows()) {
                 // Work around an issue on Windows whereby you can't rename over existing files.
                 File canonical = destFile.getCanonicalFile();
-                canonical.delete();
+                if (!canonical.delete())
+                    throw new IOException("Failed to delete canonical wallet file for replacement with autosave");
                 if (temp.renameTo(canonical))
                     return;  // else fall through.
                 throw new IOException("Failed to rename " + temp + " to " + canonical);
@@ -327,8 +328,8 @@ public void saveToFile(File temp, File destFile) throws IOException {
             if (stream != null) {
                 stream.close();
             }
-            if (temp.delete()) {
-                log.warn("Deleted temp file after failed save.");
+            if (temp.exists()) {
+                log.warn("Temp file still exists after failed save.");
             }
         }
     }