-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ECKey: switch away from the deprecated DERInteger class.
- Loading branch information
Showing
1 changed file
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2379eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you audit that ASN1Integer/DERInteger parsing is the same?
2379eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure I audited DERInteger for same-as-openssl-parsing at one point, but ASN1Integer needs the same treatment.
2379eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In BC 1.50 ASN1Integer inherits from DERInteger and in 1.51 they switched it to be the other way around, so the code crashes without this change on 1.51.
As far as I can tell, the logic itself is the same though.