Migrate from Maven to Gradle for building. #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schildbach
force-pushed
the
maven-to-gradle
branch
7 times, most recently
from
d756610
to
7cd77f9
Compare
schildbach
force-pushed
the
maven-to-gradle
branch
2 times, most recently
from
22eb699
to
702a92d
Compare
|
README.md missing change? |
schildbach
force-pushed
the
maven-to-gradle
branch
2 times, most recently
from
b300ca1
to
80aba73
Compare
|
Good catch! Amended, and rebased. |
schildbach
force-pushed
the
maven-to-gradle
branch
3 times, most recently
from
c56b3b1
to
80178a7
Compare
schildbach
force-pushed
the
maven-to-gradle
branch
5 times, most recently
from
d2e7740
to
eada969
Compare
schildbach
force-pushed
the
maven-to-gradle
branch
from
eada969
to
51d2199
Compare
schildbach
force-pushed
the
maven-to-gradle
branch
from
51d2199
to
7e905dd
Compare
|
I'll skip the signing/uploading part. I think this in fact shouldn't be part of the build process. |
schildbach
force-pushed
the
maven-to-gradle
branch
from
7e905dd
to
aaa5262
Compare
|
Merged! |
|
I'm rebasing a PR and I'm using protoc version 3.5.1. Build is success, but the generated classes are using new protobuf classes with suffix V3, e.g. Thank you so much |
|
Maybe we should exclude the generated protobuf files from version control? |
|
I think yes, since the build generates fresh ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets Gradle 3.2.1, as this is the version that will be in the upcoming Ubuntu 18.04 LTS.
You can use:
gradle cleangradle generateProtogradle buildgradle installCurrently, the protobuf classes are generated on each build. I hope this will not cause unwanted changes in these classes due to differences in protobuf libraries. If it turns out problematic, maybe in future we should not put generated classes into git.
Dependency pinning (to certain hashes) is gone for now. I doubt this will add much security if the feature isn't built into gradle itself. As long as it's a plugin, there is the trust bootstrapping problem.
Bundled jars are currently gone. If someone still needs them, please submit a PR for building them again. The Windows versions of the tool launcher scripts (e.g. wallet-tool.cmd) are gone, because I have no Windows to test with. If you have Windows, feel free to help here.
Because Gradle has no optional dependencies, there is now a dependency on
org.fusesource.leveldbjni:leveldbjni-all:1.8that you likely want to manually exclude from your build.