Upgrade to JDK 22 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if this PR is WIP it might be a good idea to use the GitHub "Draft" feature. |
We can't use it in a private repo without paying 😕 |
msgilligan
force-pushed
the
msgilligan/jdk22
branch
3 times, most recently
from
3e689ba
to
b184c65
Compare
schildbach
reviewed
Mar 8, 2024
msgilligan
force-pushed
the
msgilligan/jdk22
branch
from
b184c65
to
cebed71
Compare
* Use Java Toolchains to use JDK 22 for compile/test * Remove `--enable-preview` * Use JDK 21 for -api and -bouncy modules (we're using a JDK 21 feature in API currently, we need to backport this to en earlier JDK version) * Use JDK 21 temporarily for Kotlin examples (until Kotlin supports JDK 22) * Use BouncySecp256k1 in the Kotlin examples (which means they won't run until Bouncy is finished) but they will at least compile. * Update the extract-headers.sh script to work with JDK 22 and the latest jextract * Update OpaqueKeyPair and Secp256k1Foreign to use the JDK 22 FFM API * Replace the `o.b.s.f.jextract` Java files with the files generated by the latest jextract.
msgilligan
force-pushed
the
msgilligan/jdk22
branch
from
cebed71
to
00304d9
Compare
schildbach
approved these changes
Mar 8, 2024
I think the recommend use of |
This was referenced Mar 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve Issue #6 and Issue #9
--enable-previewo.b.s.f.jextractJava files with the files generated by the latest jextract.This is WIP because the GitHub Actions build needs an update.